Fix floating point error and refactor Bytes for value types#383
Merged
JosuaCarl merged 5 commits intonextflow-io:devfrom May 4, 2026
Merged
Fix floating point error and refactor Bytes for value types#383JosuaCarl merged 5 commits intonextflow-io:devfrom
JosuaCarl merged 5 commits intonextflow-io:devfrom
Conversation
Refactor: Rework of `Bytes` to incorporate binary & decimal-based values Test: Adjusted tests accordingly Signed-off-by: Josua Carl <[email protected]>
JosuaCarl
added
🪲 bug
# Conflicts: # CHANGELOG.md # src/testResources/cli/file_checks.json # src/testResources/cli/report_test.html # src/testResources/observer/file_checks.json # src/testResources/report/test_payload.json
Signed-off-by: Josua Carl <[email protected]>
nadnein
requested changes
May 4, 2026
Collaborator
nadnein
left a comment
nadnein
left a comment
There was a problem hiding this comment.
Nice thanks!
One small comment, I think we should mention in the docs somewhere that we use the (correct) 10^9 scaling factor for Bytes --> GB conversion and Nextflow does not and therefore it could happen that e.g. 12 GB set as memory by the user for a process is reported as 12.88 GB (SI) in the plugin output files.
Signed-off-by: Josua Carl <[email protected]>
Signed-off-by: Josua Carl <[email protected]>
nadnein
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Pull-requests
🎯 Motivation
📋 Summary of changes
✅ Checklist
testreflects class structure inmainCHANGELOG.mdis updated with a note on your changes.\gradlew check)